Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to [email protected] or use strings for numbers #24

Open
emschwartz opened this issue Feb 16, 2018 · 0 comments
Open

Upgrade to [email protected] or use strings for numbers #24

emschwartz opened this issue Feb 16, 2018 · 0 comments

Comments

@emschwartz
Copy link
Collaborator

bignumber.js made a number of breaking changes recently, which is annoying because this module returns BigNumber objects. Either we should update to the latest version of bignumber.js or change the API to use strings for numbers (if there's a chance bignumber.js will keep making breaking API changes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emschwartz