Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant revoke should be available for recuring payments #1435

Closed
3 tasks done
Tymmmy opened this issue Jul 9, 2024 · 0 comments · Fixed by #1438
Closed
3 tasks done

Grant revoke should be available for recuring payments #1435

Tymmmy opened this issue Jul 9, 2024 · 0 comments · Fixed by #1438
Assignees

Comments

@Tymmmy
Copy link
Contributor

Tymmmy commented Jul 9, 2024

Context

We have a Revoke button on the Grants Details page, that should appear for recuring payments, for example One Click Buy Grant from rafiki.boutique.

Todos

  • Check when does the Revoke button appear
  • Make sure it appears for Recurring payments for example One Click buy setup, or Web Monetization Grants - NOT NEEDED ANYMORE
  • Make sure Revoke button is not only appearing, but also working - NOT NEEDED ANYMORE

EDIT - after discussions with @mkurapov we will change this story to the following:

  • Change condition of Revoke button appearing or not to only having finalizationReason === ISSUED, we don't need to check for state
  • When user tries Revoking a payment show a generic info message: 'Revoking a grant will prevent future payments from this client. You will need to give the client access again to allow them to initiate payments.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants