Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-currency monetization #291

Closed
raducristianpopa opened this issue May 31, 2024 · 2 comments · Fixed by #451
Closed

Cross-currency monetization #291

raducristianpopa opened this issue May 31, 2024 · 2 comments · Fixed by #451
Assignees
Labels
area: background Improvements or additions to extension background script

Comments

@raducristianpopa
Copy link
Member

Context

With the current implementation from #145, we didn't really test the monetization in a cross-currency scenario.
At the moment, when performing a cross-currency transaction we get the following result for an outgoing payment:

{
    "id": "https://ilp.rafiki.money/outgoing-payments/191326a9-258e-42ec-88b1-a8944ece85de",
    "walletAddress": "https://ilp.rafiki.money/radu-ron",
    "quoteId": "https://ilp.rafiki.money/quotes/191326a9-258e-42ec-88b1-a8944ece85de",
    "receiveAmount": {
        "value": "1",
        "assetCode": "EUR",
        "assetScale": 2
    },
    "debitAmount": {
        "value": "2",
        "assetCode": "RON",
        "assetScale": 2
    },
    "sentAmount": {
        "value": "0",
        "assetCode": "RON",
        "assetScale": 2
    },
    "receiver": "https://ilp.rafiki.money/incoming-payments/702f3079-fc00-4222-aded-791aa39bbafd",
    "failed": false,
    "metadata": {
        "source": "Web Monetization"
    },
    "createdAt": "2024-05-28T06:01:23.315Z",
    "updatedAt": "2024-05-28T06:01:23.315Z"
}

When performing FX on the debitAmount (0.02 RON to EUR) it results: 0.0040EUR, but the receiveAmount is set to 1 unit of EUR (0.01EUR).

Slack thread here.

Details TBD

Todos

TBD

@raducristianpopa raducristianpopa added the triage Waiting to be assigned labels label May 31, 2024
@raducristianpopa
Copy link
Member Author

Related interledger/rafiki#2770

@tselit
Copy link

tselit commented Jun 19, 2024

This is currently blocked by a Rafiki PR: interledger/rafiki#2770

@tselit tselit added area: background Improvements or additions to extension background script and removed triage Waiting to be assigned labels labels Jun 19, 2024
@tselit tselit changed the title [Placeholder] Cross-currency monetization [TO REFINE] Cross-currency monetization Jun 19, 2024
@ioana-chiorean ioana-chiorean added this to the WM extension beta milestone Jun 25, 2024
@sidvishnoi sidvishnoi changed the title [TO REFINE] Cross-currency monetization Cross-currency monetization Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants