Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing webpack with esbuild/rollup for better sourcemaps #360

Closed
sidvishnoi opened this issue Jun 24, 2024 · 2 comments · Fixed by #500
Closed

Consider replacing webpack with esbuild/rollup for better sourcemaps #360

sidvishnoi opened this issue Jun 24, 2024 · 2 comments · Fixed by #500
Assignees
Labels
area: scripts Improvements or additions to custom scripts

Comments

@sidvishnoi
Copy link
Member

I did a quick (incomplete) test with esbuild, and could get much better sourcemaps than webpack already.

Might make sense to use rollup due to better plugin support, but haven't tested sourcemap quality yet - should be better than what webpack gives already at least.

image

@sidvishnoi sidvishnoi added the area: scripts Improvements or additions to custom scripts label Jun 24, 2024
@sidvishnoi
Copy link
Member Author

sidvishnoi commented Jun 24, 2024

Note that we'd need to update awilix container to use PROXY injection, as CLASSIC will fail with esbuild/rollyup (I verified with esbuild and wxt). See my very raw WIP esbuild branch

@sidvishnoi
Copy link
Member Author

Current sourcemaps for example:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: scripts Improvements or additions to custom scripts
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant