Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: cannot resume sessions if background script becomes inactive #413

Closed
sidvishnoi opened this issue Jul 10, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@sidvishnoi
Copy link
Member

Steps to reproduce

  1. Go to monetized website.
  2. Let some monetization happen.
  3. Go idle (switch browser to new empty tab or switch apps) for +30s
  4. Come back to monetized website later.

Expected result

Monetization should resume.

Actual result

Monetization doesn't resume, the popup says "this site is not monetized".
What happened is, as background service worker got killed, we lost this.sessions, but content script still has the details.

Screenshots or videos

No response

Additional context

Should call startPaymentSession when resuming and we've no sessions (but payload contains the session details).

Operating system

Linux

Operating system version

No response

Browsers

Chrome

Browser version

No response

Extension version

main branch as of today

@sidvishnoi sidvishnoi added bug Something isn't working triage Waiting to be assigned labels and removed triage Waiting to be assigned labels labels Jul 10, 2024
@sidvishnoi sidvishnoi added this to the WM extension beta milestone Jul 10, 2024
@sidvishnoi
Copy link
Member Author

Closing in favor of #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants