fix(background): setup payment sessions again on resume if lost #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
changed the title
|
In one of the implementation details call we said that we are going to keep the service worker (alarms APi or something else) alive. Why would we need this, if we are going to keep the worker alive? |
|
Hmmm, yeah I forgot about that lol. Let's file an issue for that. Alternatively, also consider why we might not want to keep background alive (negative effect on battery etc.) and if we can run background as needed (best result, but difficult). |
|
Closing in favor of #416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #413
Changes proposed in this pull request