Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes multiple outgoing payments are created #850

Closed
sidvishnoi opened this issue Jan 20, 2025 · 2 comments · Fixed by #851
Closed

Sometimes multiple outgoing payments are created #850

sidvishnoi opened this issue Jan 20, 2025 · 2 comments · Fixed by #851
Assignees
@sidvishnoi
Labels
bug Something isn't working
Milestone
v0.5

Comments

@sidvishnoi
Copy link
Member

sidvishnoi commented Jan 20, 2025 •
edited
Loading

For continuous payments, sometimes multiple continuous payments are created. There's still a single monetization event fired (really? and why??).

Investigate why this happens and fix it. Something related to our timers not clearing correctly and stopping/pausing payments.

This ends up showing as more payment sent out than being shown.
@sidvishnoi sidvishnoi added the bug Something isn't working label Jan 20, 2025
@sidvishnoi
Copy link
Member Author

Happens if tab is reloaded - we don't clear sessions. Caused by #831. Need a reliable way to differentiate between iframe navigation and page reload.

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Jan 20, 2025 •
edited
Loading

Some messaging from content script may hold the key. Screenshot below is after navigation of iframe (first navigation entry has a type navigate or reload correctly).

Image

@sidvishnoi sidvishnoi added this to the v0.5 milestone Jan 20, 2025
@sidvishnoi sidvishnoi moved this from Backlog to Todo in Web Monetization Extension Jan 20, 2025
This was referenced Jan 20, 2025
Open
Merged
@sidvishnoi sidvishnoi moved this from Todo to In Review in Web Monetization Extension Jan 21, 2025
@sidvishnoi sidvishnoi self-assigned this Jan 21, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Web Monetization Extension Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidvishnoi sidvishnoi

Labels
bug Something isn't working
Projects
Web Monetization Extension
Status: Done
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

fix(background): clear sessions on page reload interledger/web-monetization-extension
1 participant
@sidvishnoi