Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace prettier & eslint with Biome #814

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

chore: replace prettier & eslint with Biome #814

wants to merge 13 commits into from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jan 8, 2025 •
edited
Loading

Context

Closes #813
Closes #298

Changes proposed in this pull request

  • Use Biome for formatting and linting 🎉
  • Remove all eslint related packages and code comments
  • Disable prettier on files supported by Biome (only markdown, yaml are missing)
  • Disabled ("off", not "info") few lint rules, otherwise this PR will get too big.
  • Addressed linter and formatter feedback (lint feedback much better than what we had before, including for react).

Missing things:

@sidvishnoi
chore: use biome instead of prettier & eslint
bff8415 
Use biome for formatting, format code, some lint fixes

Continue using prettier for formatting markdown & yaml files
  as not yet supported by biome
@sidvishnoi
make lint fixes, enable more lint rules
a38ab3b 
and disable some as too many changes for this PR
@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests area: scripts Improvements or additions to custom scripts area: pages/app area: pages/notification area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities labels Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Extension builds preview

Name Link
Latest commit cedec52
Latest job logs Run #12690529546
BadgeDownload
BadgeDownload

@sidvishnoi
Copy link
Member Author

It's much easier to configure than eslint! And gave many more good recommendations out of box!

@github-actions github-actions bot added area: documentation Improvements or additions to documentation area: ci Improvements or additions to repository workflows labels Jan 8, 2025
@sidvishnoi sidvishnoi marked this pull request as ready for review January 8, 2025 12:54
sidvishnoi
sidvishnoi commented Jan 9, 2025
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

DarianM
DarianM approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Looked into docs for adding more rules, but I think we're good for now. (we'll add more as we go )
Keeping an eye open for any updates to markdown/yaml formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianM DarianM DarianM approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: ci Improvements or additions to repository workflows area: content Improvements or additions to extension content script area: documentation Improvements or additions to documentation area: pages/app area: pages/notification area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup area: scripts Improvements or additions to custom scripts area: shared Changes to shared libraries and utilities area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace prettier/eslint with Biome Add lint checks in CI and update ESLint to next major version
2 participants
@sidvishnoi @DarianM