Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to PomBase for sending genes to PombeMine #11

Closed
kimrutherford opened this issue Jan 11, 2022 · 15 comments
Closed

Add a button to PomBase for sending genes to PombeMine #11

kimrutherford opened this issue Jan 11, 2022 · 15 comments
Assignees

Comments

@kimrutherford
Copy link
Collaborator

Could you let me know what API to use to send a list to InterMine?

Thanks!

@danielabutano
Copy link
Member

@kimrutherford the new interface BG do not provide yet the /portal.do endpoint which is offered by the legacy webapp.
But we have a ticket for that with more details

@danielabutano
Copy link
Member

danielabutano commented Feb 28, 2022

@kimrutherford BG has implemented the portal.do endpoint.
Try this with your browser
'http://met1.gen.private.cam.ac.uk:5050/pombemine/portal.do?externalids=A1BG,NAT2,ADA,pom34,gls2&class=Gene'
Optional parameter:
extraValue=S.+pombe
'http://met1.gen.private.cam.ac.uk:5050/pombemine/portal.do?externalids=A1BG,NAT2,ADA,pom34,gls2&class=Gene&extraValue=S. pombe'
You can call the endpoint using the input form. In the ticket here an example

@kimrutherford
Copy link
Collaborator Author

Thanks Daniela. Your examples work for me.

I'll make the PomBase code changes once this is done: intermine/bluegenes#792

@kimrutherford
Copy link
Collaborator Author

kimrutherford commented Apr 7, 2022

I'll make the PomBase code changes once this is done: intermine/bluegenes#792

The InterMine change is done now.

@kimrutherford
Copy link
Collaborator Author

For @ValWood and @manulera:

Maybe there are enough buttons at the top right of the results page and adding another isn't a good idea. But what do you think?

Another option is to rename the "Visualise" menu to "Tools" and add a new menu item for "Send list to PombeMine".

Any other ideas?

result-buttons-1

@ValWood
Copy link
Collaborator

ValWood commented May 18, 2022

Or, change "Download" button to "Export to..." and that could be options
Download
Export to PombeMine

@kimrutherford
Copy link
Collaborator Author

Or, change "Download" button to "Export to..." and that could be options

That makes sense. Currently "Download..." is a button that opens the download dialog. We could make "Export:" a menu with "Download" and "Send to PombeMine" as items.

@kimrutherford
Copy link
Collaborator Author

We could make "Export:" a menu with "Download" and "Send to PombeMine" as items.

Sorry Val. I see that I just repeat back what you said back to you! I blame the fever.

@kimrutherford
Copy link
Collaborator Author

I think the code is ready to go for this feature. It's a bit hard to test because of the problems uploading a list on the PombeMine side (intermine/bluegenes#735 (comment))

I'm wondering what to do for japonicusdb.org. There isn't a Mine so an Export menu would just contain "Download..." It might be best to leave JaponicusDB as it is.

@kimrutherford
Copy link
Collaborator Author

How's this?:

export-menu-1

kimrutherford added a commit to pombase/website that referenced this issue May 23, 2022
kimrutherford added a commit to pombase/website that referenced this issue May 23, 2022
This is only shown on pombase.org and contains "Download" and a link to
send the results to PombeMine

Refs intermine/pombemine#11
@ValWood
Copy link
Collaborator

ValWood commented May 23, 2022

I did not notice! I blame post-covid brain fog.

Yes, exactly. Added bonus (or not) is that more people will see it.

@ValWood
Copy link
Collaborator

ValWood commented May 23, 2022

I'm wondering what to do for japonicusdb.org. There isn't a Mine so an Export menu would just contain "Download..." It might be best to leave JaponicusDB as it is.

Probably, if it is easy to configure. There was talk of doing a japoniccus MIne too but I don't want to get side-tracked by that. It should be straightforward, but of course it never I,s and it would be extra work to configure etc. If there is a demand it could be done in future.

@kimrutherford
Copy link
Collaborator Author

It might be best to leave JaponicusDB as it is.

Probably, if it is easy to configure.

Yep! I implemented it such that if no Mine is configured, we just have a "Download..." button like always. If there is a Mine configured, it shows a menu with two items. So japonicusdb.org won't changed look until (if ever) there is a Mine for it.

The current status is that the code is finished (I think) and committed, but I haven't added the configuration for PomBase to enable it. I'll add the config when PombeMine it fixed so we can test it.

@danielabutano
Copy link
Member

@kimrutherford pombemine uses BG 1.4.2 whch contains the support for HTTP clients using POST portal.do. Anything else that needs to be fixed?

@kimrutherford
Copy link
Collaborator Author

Hi @danielabutano @heralden

I just tested POSTing a list to portal.do and it works perfectly. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants