Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better search #163

Closed
oskarrough opened this issue Nov 28, 2017 · 8 comments
Closed

Better search #163

oskarrough opened this issue Nov 28, 2017 · 8 comments
Assignees

Comments

@oskarrough
Copy link
Member

The search we have on /all only searches the data we already have in the store. It doesn't scale. We need something that scales. This would also allow us to continue with pagination.

Projects to consider

@4www
Copy link
Contributor

4www commented Dec 24, 2017

css selectors in js https://sizzlejs.com/

@oskarrough
Copy link
Member Author

oskarrough commented Mar 5, 2018

I tried out Algolia again and here's a little status report.

They have a free "community plan" with a limit to 10k records. So we can't use it for tracks but it'll work fine for radios.

Updating the search index from Firebase is pretty easy. I followed this guide https://www.algolia.com/doc/tutorials/indexing/3rd-party-service/firebase-algolia/. And we can customize the ranking with last updated, amount of tracks etc.

Some tests:

@oskarrough
Copy link
Member Author

Made a repo with the node script that generates the search index. Just in case :]

https://github.com/internet4000/radio4000-search-index

@oskarrough
Copy link
Member Author

@4www
Copy link
Contributor

4www commented Jan 16, 2019

We need to refactor/unify/improve how search works on our app, on many routes. Anfixea few bugs that prevent some search to work correctly; quick list:
PR: #298 (algolia for channels)
Issues:

@oskarrough oskarrough self-assigned this Jan 16, 2019
@4www
Copy link
Contributor

4www commented Jan 17, 2019

deepinscreenshot_select-area_20190117104258
Fig . something not stupid, quick jump search available everywhere, first result being "go to detailed search result", and all the next results (1 + n ) are quick jumps to the project.

For r4 it could be the same

  1. first result goes to a detailed search result page
  2. all other results are the quick jump like implemented in Add input-autocomplete for Algolia search #298

@4www
Copy link
Contributor

4www commented Sep 4, 2019

Think we have something now that fixes this issue. Search is always something to improve, but it is a new issue now.

@4www 4www closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants