Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Automated Pull Request Merging,Optionally After Sufficient Review #337

Open
xloem opened this issue Jan 20, 2021 · 2 comments
Open

Comments

@xloem
Copy link
Contributor

xloem commented Jan 20, 2021

See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request .

This project looks pretty important, so it would be great to make sure there are ways for it to continue on its own when the maintainers are busy.

@mitra42
Copy link
Collaborator

mitra42 commented Jan 21, 2021

Hi, I'm not sure auto-merge is going to work, partly because currently I'm the only one who has spent a lot of time on the code, so I might catch something otherwise missed, and if I have to review anyway then its just as easy for me to click the "merge" button at the same time.

Even though I'm no longer working on the project, I'm generally pretty available for code-review and merges, though I'm on Australia time.

Glad you are working on it - thanks for catching problems with the installer - which is a bit surprising given that I've had it working on multiple platforms (OSX, Intel, OLIP, IIAB, Rachel), the OSX is pretty cooked - i.e. I've already got stuff installed - but the other platforms are raw out-of-the-box installs.

@mitra42
Copy link
Collaborator

mitra42 commented Jan 21, 2021

By the way ... if you are testing and in a position to confirm that yarn update or similar gets the newer packages with no problems I could merge the dependabot PR's -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants