Favicon Internet.nl still visible in non-branded version

[baknu]

No description provided.

[bwbroersma]

Currently the security.txt is done this way:

Internet.nl/docker/webserver/nginx_templates/app.conf.template

Lines 234 to 247 in 88a1f10

	# disable security.txt if branding is disabled
	set $internetnl_branding "${INTERNETNL_BRANDING}";
	if ($internetnl_branding = "True"){
	set $security_txt "/var/www/internet.nl/.well-known/security.txt";
	}
	if ($internetnl_branding != "True"){
	set $security_txt "/var/www/internet.nl/.well-known/security-custom.txt";
	}
	location = /.well-known/security.txt {
	# basic auth should not apply to this path
	auth_basic off;
	# IP allowlist should also not apply
	alias $security_txt;
	}

This uses the template nginx docker 20-envsubst-on-templates.sh logic. Note that nginx env is an alternative to this.
Maybe it's better to use:

http {
  env $INTERNETNL_BRANDING;
  map $INTERNETNL_BRANDING $branding_assets {
    True    "/var/www/internet.nl/";
    default "/var/www/no_branding/";
  }
  ...
  server {
     ...
    location = /.well-known/ { 
      # basic auth should not apply to this path 
      auth_basic off; 
      # IP allowlist should also not apply 
      root $branding_assets;
    }
    location = /favicon.ico {
      root $branding_assets;
    }
    ...
  }
  ...
}

Either root or alias should be used.

Variant	$ tree -a
root $assets;	├── favicon.ico ├── static │   ├── logo_en.svg │   └── logo_nl.svg └── .well-known └── security.txt
alias $assets;	├── favicon.ico ├── logo_en.svg ├── logo_nl.svg └── security.txt

Note that the logo currently is not a branding option, and not as easy as it seems since it's this in the HTML:

<a href="/">
  <span class="hidden">Internet.nl</span>
</a>

A no_branding variant should be there by default. Another option is to call it your_branding, so this can be changed in some branding.yml override with an extra mount.