settingsUIReadOnly=1 prevents user from changing between Basic and Expert modes

[raymond-rebbeck]

With settingsUIReadOnly=1 a user is not able to change between Basic and Expert modes on the Settings screen.

This behaviour seems unintended as the Basic/Expert/Default selection combo box is not disabled like every other setting and grouped with the user's name and email which is editable, seems like it should be something the user can choose.

When attempting to change this setting the expected 'Success! Your settings have been saved' message is shown but this setting is not actually changed.

I'm not sure if this was ever actually possible to change but installing a few different versions suggests that this goes at least as far back as 2.7.1. Releases since and current main have the same behaviour.

IRIS for UNIX (Ubuntu Server LTS for x86-64 Containers) 2024.1 (Build 267_2U) Tue Apr 30 2024 16:04:37 EDT

[raymond-rebbeck]

While investigating #780 I noticed that %request.Data does specify basicMode when settingsUIReadOnly=1, along with the name/email values that users can change. Suggesting that it could/should be able to be altered.

However setting basicMode is only performed when settingsUIReadOnly'=1 here:

git-source-control/csp/gitprojectsettings.csp

Line 111 in 4cea6ab

if ('settings.settingsUIReadOnly) {

git-source-control/csp/gitprojectsettings.csp

Lines 128 to 134 in 4cea6ab

	if ($Get(%request.Data("basicMode", 1)) = 1) {
	set settings.basicMode = 1
	} elseif ($Get(%request.Data("basicMode", 1)) = "system"){
	set settings.basicMode = "system"
	} else {
	set settings.basicMode = 0
	}

[isc-pbarton]

Fixed by #782