Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record username in ZPM.Analytics.Event #448

Closed
scanzano-bcbssc opened this issue Mar 21, 2024 · 2 comments
Closed

Record username in ZPM.Analytics.Event #448

scanzano-bcbssc opened this issue Mar 21, 2024 · 2 comments
Labels
invalid This doesn't seem right

Comments

@scanzano-bcbssc
Copy link

In the class ZPM.Analytics.Event which is used to track the events done for a module, ie
install

  • install
  • uninstall
  • download
    etc

I would like to see the following added

/// The username of the person that performed the action
Property Username As %String [ SqlComputeCode = {set {*}=$Username}, SqlComputed, SqlComputeOnChange = %%INSERT ];

so as to be able to track who is performing the actions.

Our practice is to

  1. standup our own private repo/registry
  2. Provide username and password commonly based on customer names, although not exclusively customer names, they are sometimes personal names
  3. Use the data in ZPM_Analytics.Event to determine who has performed what actions. It's not clear that fields like
  • city
  • country
  • region
    are ever populated and fields like
    -GUID
    -IP
    provide any meaningful insight

Adding this single property declaration should be completely safe and transparent to users.

@isc-tleavitt
Copy link
Contributor

@scanzano-bcbssc ZPM.Analytics.Event is part of the zpm-registry package, so this issue belongs here: https://github.com/intersystems-community/zpm-registry/issues

@isc-tleavitt isc-tleavitt added the invalid This doesn't seem right label Mar 21, 2024
@isc-tleavitt
Copy link
Contributor

Covered here: intersystems-community/zpm-registry#109

@isc-tleavitt isc-tleavitt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants