Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define separate Threshold and WeighedThreshold types #74

Closed
rofinn opened this issue Oct 10, 2020 · 0 comments · Fixed by #90
Closed

Define separate Threshold and WeighedThreshold types #74

rofinn opened this issue Oct 10, 2020 · 0 comments · Fixed by #90
Milestone
0.6

Comments

@rofinn
Copy link
Member

rofinn commented Oct 10, 2020

As of #69 a Threshold type was define that may take weights. Since the code is sufficiently different between these two thresholds it may be better to just have separate types.
@rofinn rofinn mentioned this issue Oct 10, 2020
Merged
10 tasks
@rofinn rofinn added this to the 0.6 milestone Oct 10, 2020
rofinn added a commit that referenced this issue Oct 21, 2020
@rofinn
Separate Threshold and WeightedThreshold closing #74
c56c03e
@rofinn rofinn mentioned this issue Oct 21, 2020
Merged
@rofinn rofinn closed this as completed in #90 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Separate weighted types invenia/Impute.jl
1 participant
@rofinn