Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming Assertion #75

Closed
rofinn opened this issue Oct 10, 2020 · 1 comment · Fixed by #86
Closed

Consider renaming Assertion #75

rofinn opened this issue Oct 10, 2020 · 1 comment · Fixed by #86
Milestone

Comments

@rofinn
Copy link
Member

rofinn commented Oct 10, 2020

#69 Introduced an abstract Assertion type to define a set tests/checks/assumptions about datasets containing missings. Perhaps there's a more appropriate name than just "assertion" for that?

@rofinn rofinn mentioned this issue Oct 10, 2020
10 tasks
@rofinn rofinn added this to the 0.6 milestone Oct 10, 2020
@rofinn
Copy link
Member Author

rofinn commented Oct 16, 2020

I suppose this could also be called a MissingDataCheck and you could call check(...) (vs assert(...))? Alternative, I could see something like Impute.Validator which implements isvalid(data, ::Validator) -> Bool and verify(data, ::Validator) -> data which might remain relatively general, but doesn't overlap with @assert in base? I do feel like these should be used like traditional assert statements on assumption about the input and outputs to a functions though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant