Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: fork or integrate Flask-KVSession #289

Closed
slint opened this issue Nov 19, 2019 · 3 comments · May be fixed by #292
Closed

global: fork or integrate Flask-KVSession #289

slint opened this issue Nov 19, 2019 · 3 comments · May be fixed by #292
Assignees
@diegodelemos @Glignos

Comments

@slint
Copy link
Member

slint commented Nov 19, 2019

Flask-KVSession is currently abandoned (but simplekv is not). There are a couple of issues/features that are necessary for supporting SameSite cookies, and client-side sessions.

To address these, the package has to either be forked in inveniosoftware, or integrated inside invenio-accounts (e.g. in session.py). Forking seems to be the better option at the moment since we would also keep the existing unit tests of the package.
@ppanero
Copy link
Member

ppanero commented May 7, 2020

Released as https://pypi.org/project/Flask-KVSession-Invenio/

@Glignos Glignos self-assigned this May 7, 2020
diegodelemos pushed a commit to drjova/invenio-accounts that referenced this issue May 8, 2020
installation: use Flask-KVSession-Invenio fork
382f8b8 
* Closes inveniosoftware#289.
@ntarocco
Copy link
Contributor

ntarocco commented May 9, 2020

@diegodelemos @ppanero @Glignos shouldn't we change the URL in the setup.py?
I am not sure what is the best thing to do in case of forking and releasing forked packages, but I went on PyPi and the URL is to the original repo... a bit misleading.

@ppanero
Copy link
Member

ppanero commented May 11, 2020

@ntarocco yes, my bad. Added to inveniosoftware/flask-kvsession#6

diegodelemos pushed a commit to diegodelemos/cookiecutter-invenio-instance that referenced this issue May 11, 2020
config: configure Flask-KVSession
1f897b4 
* Closes inveniosoftware/invenio-accounts#289.
@diegodelemos diegodelemos mentioned this issue May 11, 2020
Closed
@drjova drjova mentioned this issue May 11, 2020
Open
diegodelemos pushed a commit to diegodelemos/cookiecutter-invenio-instance that referenced this issue May 11, 2020
config: configure Flask-KVSession
2ad70d9 
* Closes inveniosoftware/invenio-accounts#289.
Glignos pushed a commit to Glignos/invenio-accounts that referenced this issue May 11, 2020
@Glignos
installation: use Flask-KVSession-Invenio fork
02957f6 
* Closes inveniosoftware#289.
@ppanero ppanero mentioned this issue May 12, 2020
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegodelemos diegodelemos

@Glignos Glignos

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@slint @ntarocco @drjova @ppanero @diegodelemos @Glignos