Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issue when search returns 0 results with filtered facets #111

Open
dfdan opened this issue Mar 7, 2018 · 2 comments
Open

UI issue when search returns 0 results with filtered facets #111

dfdan opened this issue Mar 7, 2018 · 2 comments
Milestone

Comments

@dfdan
Copy link
Member

dfdan commented Mar 7, 2018

The screenshot below shows a problematic state for the search ui.

Having narrowed by section=an at the previous step and entering a new search with 0 results in section=an. However results exist in other sections, it is not apparent (other than in the URL) that you are still filtering for section=an

I'm not sure what the best solution here is - perhaps showing "an (0)" selected in the facet control?

screen shot 2018-03-07 at 12 37 57

You can re-create this at http://bth-invenio.data-futures.org/ with the following steps

1 - search "season"
2 - filter for section "an"
3 - search "werk"

@lnielsen lnielsen added this to the v1.0.0 milestone Mar 11, 2018
@slint slint self-assigned this Mar 20, 2018
slint added a commit to slint/invenio-search-js that referenced this issue Mar 20, 2018
* Shows top-level selected values from previously selected facets that
  have zero results. (closes inveniosoftware#111)
@slint
Copy link
Member

slint commented Mar 20, 2018

This is addressed by #117. The changes involved are actually part of the default facets.html template.

It works for the use-case mentioned by OP (i.e. top-level facets) but doesn't work for deeply nested aggregations, since the hierarchy is not persisted in any way in the parameter...

The changes involved to make this possible might include a serious reworking of how configuration or search parameter state is stored for facets/aggregations.

slint added a commit to slint/invenio-search-js that referenced this issue Mar 20, 2018
* Shows top-level selected values from previously selected facets that
  have zero results. (closes inveniosoftware#111)
slint added a commit to slint/invenio-search-js that referenced this issue Mar 20, 2018
* Shows top-level selected values from previously selected facets that
  have zero results. (addresses inveniosoftware#111)
lnielsen pushed a commit that referenced this issue Mar 20, 2018
* Shows top-level selected values from previously selected facets that
  have zero results. (addresses #111)
@slint slint removed their assignment Jun 1, 2018
@carlinmack
Copy link

Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants