Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Barcode scanning #8732

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

[WIP] Barcode scanning #8732

wants to merge 28 commits into from

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Dec 20, 2024 •
edited
Loading

Overview

This PR implements the "quick scan" dialog functionality in the new user interface, as well as refactoring / further features for the "barcode actions" page.

The "scan barcode" dialog has now been refactored into a common component, with support for:

  • Camera scanning
  • USB scanning
  • Raw keyboard input

Related Issues

TODO

  • Playwright testing
  • Improved documentation
  • Prevent duplicate scans
  • Implement some actions
  • Fix issue deleting "last" item (or all items at once)

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature barcode Barcode scanning and integration refactor Platform UI Related to the React based User Interface labels Dec 20, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 20, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 29f412a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/676b2dc047d6f700089bd2fa
😎 Deploy Preview https://deploy-preview-8732--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.37906% with 179 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (c79fc28) to head (29f412a).

Files with missing lines Patch % Lines
...end/src/components/barcodes/BarcodeCameraInput.tsx 4.47% 64 Missing ⚠️
src/frontend/src/pages/Index/Scan.tsx 29.72% 25 Missing and 1 partial ⚠️
src/frontend/src/functions/api.tsx 0.00% 24 Missing ⚠️
...tend/src/components/barcodes/BarcodeScanDialog.tsx 32.25% 21 Missing ⚠️
...d/src/components/barcodes/BarcodeKeyboardInput.tsx 13.33% 13 Missing ⚠️
...c/frontend/src/tables/general/BarcodeScanTable.tsx 58.33% 10 Missing ⚠️
.../frontend/src/components/barcodes/BarcodeInput.tsx 68.00% 4 Missing and 4 partials ⚠️
...nd/src/components/barcodes/BarcodeScannerInput.tsx 66.66% 4 Missing and 1 partial ⚠️
src/frontend/src/components/items/QRCode.tsx 37.50% 4 Missing and 1 partial ⚠️
src/frontend/src/hooks/UseTable.tsx 50.00% 0 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8732      +/-   ##
==========================================
- Coverage   85.20%   85.16%   -0.05%     
==========================================
  Files        1172     1174       +2     
  Lines       51538    51545       +7     
  Branches     2089     2077      -12     
==========================================
- Hits        43911    43896      -15     
- Misses       7118     7131      +13     
- Partials      509      518       +9
Flag Coverage Δ
backend 86.97% <100.00%> (+<0.01%) ⬆️
pui 68.70% <34.43%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair Awaiting requested review from matmair matmair is a code owner

Assignees
No one assigned
Labels
barcode Barcode scanning and integration enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface refactor
Projects
None yet
Milestone
1.0.0
1 participant
@SchrodingersGat