Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: pub dev package & rework iOS build phase #223

Open
1 task done
EArminjon opened this issue Oct 21, 2023 · 9 comments
Open
1 task done

request: pub dev package & rework iOS build phase #223

EArminjon opened this issue Oct 21, 2023 · 9 comments
Labels
blocked: customer-response Waiting for customer response, e.g. more information was requested. enhancement New feature or request

Comments

@EArminjon
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

flutterfire

Description

I saw some packages providing cli like flutter_native_splash using the dart command. (ex: dart run flutter_native_splash:create)

I think it can be interesting to have a similar usage for this script as it depend of dart. Installing this tool inside project dev-dependencies instead of global system command will be better.
If you have several projects using several flutter versions, it's a nightmare to handle this good command...

Today, the flutterfire script is launched when we build or run the app. It make sens to put it as project dependency.

Instead of having something like :

#!/bin/bash
PATH=${PATH}:$FLUTTER_ROOT/bin:$HOME/.pub-cache/bin
flutterfire bundle-service-file ...

We could have something like :

#!/bin/bash
PATH=${PATH}:$FLUTTER_ROOT/bin
dart run flutterfire bundle-service-file ...

This will remove the dependency of the $HOME and I think this will be better for projects using tools like FVM.

Reasoning

Help developers to integrate easily this package.
Help developers to work easily on multiple flutter project using different dart and flutter version.

Additional context and comments

No response

@EArminjon
Copy link
Author

Update : Removing on my side my fvm 'global' version and my 'dart' global binary help me to bypass a problem around multiple version of dart.

I keep this PR open because I believe that it can be a good things to have a migration from dart global to project dev-dependency.

@ebsangam
Copy link

Exactly currently we were having this issue because of different flutterfire version in our system and it was really hard to identify the issue.

@russellwheatley russellwheatley added enhancement New feature or request and removed triage labels Feb 29, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 30, 2024
@EArminjon
Copy link
Author

This issue still requires attention I guess.

@github-actions github-actions bot added Needs Attention OP created or responded to issue and it needs attention. and removed Stale labels Sep 30, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 28, 2024
@EArminjon
Copy link
Author

I keep this PR open because I believe that it can be a good things to have a migration from dart global to project dev-dependency.

@github-actions github-actions bot removed the Stale label Oct 28, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 25, 2024
@EArminjon
Copy link
Author

Still think that it could be considered?

@github-actions github-actions bot removed the Stale label Nov 25, 2024
@russellwheatley
Copy link
Member

Hey @EArminjon - I am interested in making this possible. Sorry, I forgot that there was another issue open for this. You've already correctly identified the problem with making it a dev dependency as I've noted here: #242 (comment)

If you want to raise a PR for this feature, I'd help you get it over the line.

@russellwheatley russellwheatley removed the Needs Attention OP created or responded to issue and it needs attention. label Dec 18, 2024
@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Dec 18, 2024
@russellwheatley russellwheatley added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention OP created or responded to issue and it needs attention. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: customer-response Waiting for customer response, e.g. more information was requested. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants