fix: Exit code not properly returned when using steps

[bvoq]

Is there an existing issue for this?

• I have searched the existing issues.

Version

6.1.0

Description

Adding the following step will lead to a zero exit code, even when the test is supposed to fail.

scripts:
  test:
    steps:
      - melos exec -f --dir-exists=test -- flutter test

If you run melos test I would expect a non-zero exit code, however I get exit code 0.
However, if you run melos exec -f --dir-exists=test -- flutter test directly, you will get exit code 1.

Steps to reproduce

Add any failing test to your project.
Then add the above script to melos.yaml.
Then run melos test which should throw a non-zero exit code.

Expected behavior

I would expect a non-zero exit code but I get a zero exit code.

Screenshots

No response

Additional context and comments

This was tested on macOS but I don't think it's platform specific.

[spydon]

This is a duplicate of #527
Which you also commented on...

[bvoq]

This is a duplicate of #527 Which you also commented on...

Ok thanks, I wasn't sure if I needed to file a new issue.
Thanks for maintaining this cool tool :-)

[spydon]

Ah, this is actually not a duplicate, I'm re-opening this one.

[spydon]

@jessicatarra could you maybe have a look at this one? :)

[Isakdl]

I ran into this today, any updates?

[spydon]

I ran into this today, any updates?

No updates, but we're open to PRs!

[christerswahn]

This issue should be high priority to fix, it unfortunately makes melos unreliable to use in any scripting including CI.

Are you adressing it?

It seems the culprit is in persistent_shell.dart which swallows the exit code:

  Future<void> stopShell() async {
    await _process.stdin.close();
    final exitCode = await _process.exitCode;
    if (exitCode == 0) {
      logger.log(successLabel);
      return;
    }
    logger.log(failedLabel);
  }

[spydon]

@christerswahn feel free to submit a PR, this issue isn't assigned to anyone currently (tell me if you plan to and I'll assign you).

A workaround meanwhile is to not use steps, but use a script separated by && like before the steps feature existed.

[christerswahn]

I made a fork of your repo to see if it was a difficult fix or not, but the test suite failed out of the box (formatting checking tests it seemed) so I gave up on that.

[spydon]

I made a fork of your repo to see if it was a difficult fix or not, but the test suite failed out of the box (formatting checking tests it seemed) so I gave up on that.

What OS are you on? The test suite passes for me, but I know it does have some flaky/broken tests in the CI too unfortunately (#724).

EDIT: also make sure that you've activated the local Melos before running the test suite.

[christerswahn]

What OS are you on? The test suite passes for me, but I know it does have some flaky/broken tests in the CI too unfortunately (#724).
EDIT: also make sure that you've activated the local Melos before running the test suite.

I'm on MacOS, using Bash 5. Yes I activated local Melos.

[christerswahn]

I made a first PR to fix the failing test cases. If this is approved and merged I could go ahead and look at this actual issue.

#799