Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update major version on preid #809

Open
1 task done
Tristan-gu opened this issue Dec 27, 2024 · 0 comments
Open
1 task done

fix: update major version on preid #809

Tristan-gu opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Tristan-gu
Copy link

Tristan-gu commented Dec 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Version

6.2.0

Description

When you are working on preid version, if you commit a breaking change, the major version is not updating.

See discussion for details.

Steps to reproduce

  1. create a preid version
  2. push a breaking change commit
  3. create a new preid version

Expected behavior

Honnestly, I read docs here SemVer, and I don't find exactly what we are supposed to do in this situation.

As far as I'm concerned, there's a lack of clarity on this subject, especially when it comes to pre-release versions.
I don't know whether you absolutely have to mount the major version or not in the case of a pre-release, because in that case, it's the same thing for the minor version and the patch.

If you mount the version in all cases, for the consumer of the pre-release library, it's going to be complicated to follow because if the version goes from 1.0.0.beta.0 to 1.1.2.beta.1 for example, you'll never be able to declare the dependency in the pubspec.yaml in this way

my_package: ^1.0.0.beta.0

But only in this way

my_package: '>=1.0.0 <2.0.0'

I'm not sure this is the best way to declare dependancies.

Screenshots

No response

Additional context and comments

No response

@Tristan-gu Tristan-gu added the bug Something isn't working label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant