app crashes on iOS after pressing notification while app in background

[ElChawich]

i'm facing an issue when i tap the received push notification while the app is in background, where my app gives fatal error "Call must be made on main thread, was thrown while invoking complete on target RNFirebaseNotifications", and i applied the solution mentioned here which in summary is adding dispatch_sync to the completion handler of didReceiveNotificationResponse in AppDelegate.m, yet it didn't work.

Iam using firebase v5.5.7

This is my AppDelegate.m

// Required to register for notifications
- (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
{
 [RNCPushNotificationIOS didRegisterUserNotificationSettings:notificationSettings];
}
// Required for the register event.
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
 [RNCPushNotificationIOS didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
}
// Required for the notification event. You must call the completion handler after handling the remote notification.
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo
fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler
{
  [RNCPushNotificationIOS didReceiveRemoteNotification:userInfo fetchCompletionHandler:completionHandler];
}
// Required for the registrationError event.
- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
{
 [RNCPushNotificationIOS didFailToRegisterForRemoteNotificationsWithError:error];
}
// IOS 10+ Required for localNotification event
- (void)userNotificationCenter:(UNUserNotificationCenter *)center
didReceiveNotificationResponse:(UNNotificationResponse *)response
         withCompletionHandler:(void (^)(void))completionHandler
{
  [RNCPushNotificationIOS didReceiveNotificationResponse:response];
  [RnAlarmNotification didReceiveNotificationResponse:response];
  dispatch_sync(dispatch_get_main_queue(), ^{
      completionHandler();
    });
}

- (void)userNotificationCenter:(UNUserNotificationCenter *)center
       willPresentNotification:(UNNotification *)notification withCompletionHandler: (void (^)(UNNotificationPresentationOptions options))completionHandler {
  [RnAlarmNotification didReceiveNotification:notification];
  completionHandler(UNAuthorizationOptionSound | UNAuthorizationOptionAlert | UNAuthorizationOptionBadge);
}

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  if ([FIRApp defaultApp] == nil) {
    [FIRApp configure];
  }
  
  RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
  RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
                                                   moduleName:@"CCMM"
                                            initialProperties:nil];
  
  rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];

  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
  UIViewController *rootViewController = [UIViewController new];
  rootViewController.view = rootView;
  self.window.rootViewController = rootViewController;
  [self.window makeKeyAndVisible];
  
  UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter];
    center.delegate = self;
  
  return YES;
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
{
#if DEBUG
  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
#else
  return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
#endif
}

@end

I found this block in FNFirebaseNotifications.m

// Handle notification messages after display notification is tapped by the user.
- (void)userNotificationCenter:(UNUserNotificationCenter *)center
didReceiveNotificationResponse:(UNNotificationResponse *)response
#if defined(__IPHONE_11_0)
         withCompletionHandler:(void(^)(void))completionHandler NS_AVAILABLE_IOS(10_0) {
#else
         withCompletionHandler:(void(^)())completionHandler NS_AVAILABLE_IOS(10_0) {
#endif
     NSDictionary *message = [self parseUNNotificationResponse:response];
           
     NSString *handlerKey = message[@"notification"][@"notificationId"];

     [self sendJSEvent:self name:NOTIFICATIONS_NOTIFICATION_OPENED body:message];
     if (handlerKey != nil) {
         completionHandlers[handlerKey] = completionHandler;
     } else {
         completionHandler();
     }
}

After i added the dispatch_async in the last if else the issue remained, then after changing async to sync, m getting this error "Thread 1: EXC_BREAKPOINT (code=1, subcode=0x1029b4be0)" on the dispatch_sync line.

That’s how i added it

if (handlerKey != nil) {
         dispatch_sync(dispatch_get_main_queue(), ^{
         completionHandlers[handlerKey] = completionHandler;
         });
     } else {
         dispatch_sync(dispatch_get_main_queue(), ^{
         completionHandler();
         });
     }

[mikehardy]

firebase v5.x.x will receive no support, sorry. It's getting close to a year out of support. This is an example of a way it does not work.

Please update to v10.1.0 (current stable versions) of everything and see if you can reproduce

If you persist in using v5.x.x, you may find this issue is addressed in the issues list - others have seen it. I believe it's working in current stable versions

[ElChawich]

@mikehardy I'm using RN v0.59.5, and i saw that firbase v6+ needs RN v0.60+, if i upgrade to v10 will it work or it won't

[mikehardy]

I can't imagine even trying to submit an app to Play Store or App Store based on RN59 anymore. The changelist for react-native upgrades, when filtered for the idea of "required to support ios13/ios14 + android10/android11" is large. I am usually pretty direct in comments but in this case I will be even more direct, blunt even: upgrade now. Schedule it, do it. You need to upgrade. It's time.

[mikehardy]

Slightly less blunt, maybe more helpful, have you seen https://react-native-community.github.io/upgrade-helper/ ? Makes upgrading not so bad. Do it one major version at a time, looking at the diffs from that project. It's achievable

[ElChawich]

@mikehardy thank you for your help