fix(dart_test_adapter): use valid SDK executable for tests #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrverdant13 great start on this, let me know when you think it's ready for review. I noticed some tests are still failing explicitly relating to these changes |
|
👋 Do you still plan on working on this? |
|
It appears that you have given-up on this PR, so I'll close this. Feel free to open a new PR if you want to resume this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Retrieve de default SDK executable by checking the available runnable files for both Dart and Flutter, keeping their priority order according to the environment, and filtering them as follows:
.exeand.bat..shandThis filtering step is required since Dart and Flutter installation includes all possible executables (no matter the target platform) and the
Process.startdoes not validate if they are actually runnable in the client platform.Related Issues