From faf7cfe7e92504afac626bc2df944f48d1554a6b Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Sun, 19 May 2024 13:10:17 +0300 Subject: [PATCH 1/2] Fixes for task rounding --- lib/data/models/settings_model.dart | 5 +++-- lib/ui/settings/task_settings.dart | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/data/models/settings_model.dart b/lib/data/models/settings_model.dart index 84e40b578a..56c89d1c93 100644 --- a/lib/data/models/settings_model.dart +++ b/lib/data/models/settings_model.dart @@ -843,8 +843,9 @@ abstract class SettingsEntity taskRoundToNearest == null ? null : taskRoundToNearest != 1; bool get isTaskRoundingCustom => - taskRoundToNearest == 0 || - !kTaskRoundingOptions.values.contains(taskRoundToNearest); + taskRoundingEnabled == true && + (taskRoundToNearest == 0 || + !kTaskRoundingOptions.values.contains(taskRoundToNearest)); bool get hasAddress => address1 != null && address1!.isNotEmpty; diff --git a/lib/ui/settings/task_settings.dart b/lib/ui/settings/task_settings.dart index 693b3272b4..1b0d4ec555 100644 --- a/lib/ui/settings/task_settings.dart +++ b/lib/ui/settings/task_settings.dart @@ -161,7 +161,7 @@ class _TaskSettingsState extends State { viewModel.onSettingsChanged(settings.rebuild( (b) => b ..taskRoundToNearest = value == true - ? 60 * 5 + ? 60 * 15 : value == false ? 1 : null, From 0a338589bd76370ea9a78e73b91d076c8ad08b1c Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Sun, 19 May 2024 13:20:38 +0300 Subject: [PATCH 2/2] Show product image if link is set --- .../product/view/product_view_overview.dart | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/lib/ui/product/view/product_view_overview.dart b/lib/ui/product/view/product_view_overview.dart index 272b7601a2..44acd7aa65 100644 --- a/lib/ui/product/view/product_view_overview.dart +++ b/lib/ui/product/view/product_view_overview.dart @@ -110,10 +110,6 @@ class _ProductOverviewState extends State { formatNumberType: FormatNumberType.int); } - if (product.imageUrl.isNotEmpty) { - fields[localization.imageUrl] = product.imageUrl; - } - return ScrollableListView( children: [ EntityHeader( @@ -127,13 +123,24 @@ class _ProductOverviewState extends State { ), ListDivider(), FieldGrid(fields), - Padding( - padding: EdgeInsets.all(20), - child: Text( - product.notes, - style: TextStyle(fontSize: 16), + if (product.notes.isNotEmpty) + Padding( + padding: EdgeInsets.only(left: 20, top: 20, right: 20), + child: Text( + product.notes, + style: TextStyle(fontSize: 16), + ), ), - ), + if (product.imageUrl.isNotEmpty) + Padding( + padding: EdgeInsets.only(left: 20, top: 20, right: 20), + child: Image.network( + product.imageUrl, + width: double.infinity, + fit: BoxFit.contain, + ), + ), + SizedBox(height: 20), ], ); }