feat(se): remove unnecessary checks

Author: BoscoDomingo

regimes/se/invoices.go

@@ -71,10 +71,8 @@ func validateOrgParty(value any) error {
 				party.TaxID != nil && party.TaxID.Country == l10n.TaxCountryCode(l10n.SE),
 				validation.Each(
 					validation.By(func(value any) error {
-						id, ok := value.(*org.Identity)
-						if !ok || id == nil {
-							return nil
-						}
+						// Casting to org.Identity is safe, as the identity type is validated before this function is called
+						id, _ := value.(*org.Identity)
 						if !id.Type.In(IdentityTypeOrgNr, IdentityTypePersonNr, IdentityTypeCoordinationNr) {
 							return validation.NewError("type", "must be one of: SE-ON, SE-PN, SE-CN")
 						}
@@ -90,10 +88,8 @@ func validateOrgParty(value any) error {
 // validateSupplier checks the supplier's tax ID requirements.
 // The supplier's VAT number is always required.
 func validateSupplier(value any) error {
-	party, ok := value.(*org.Party)
-	if !ok || party == nil {
-		return nil
-	}
+	// Casting to org.Party is safe, as the party is validated before this function is called
+	party, _ := value.(*org.Party)
 
 	return validation.ValidateStruct(party,
 		// Swedish Tax ID (VAT ID) is always required for the supplier,
@@ -114,10 +110,8 @@ func validateSupplier(value any) error {
 }
 
 func validateSupplierSimplifiedInvoice(value any) error {
-	party, ok := value.(*org.Party)
-	if !ok || party == nil {
-		return nil
-	}
+	// Casting to org.Party is safe, as the party is validated before this function is called
+	party, _ := value.(*org.Party)
 
 	return validation.ValidateStruct(party,
 		validation.Field(&party.Name,

regimes/se/org_identities.go

@@ -72,10 +72,7 @@ var identityTypeDefinitions = []*cbc.Definition{
 //
 // If too many or too few numbers are present, it does nothing.
 func normalizeOrgIdentity(id *org.Identity) {
-	if id == nil {
-		return
-	}
-
+	// No need for nil check, as the identity type is validated before this function is called
 	switch id.Type {
 	case IdentityTypeOrgNr:
 		// Organization numbers should be numeric only, with no separators
@@ -143,9 +140,7 @@ func normalizeOrgIdentity(id *org.Identity) {
 //
 // If the organization type is not valid, it returns nil.
 func validateOrgIdentity(id *org.Identity) error {
-	if id == nil {
-		return nil
-	}
+	// No need for nil check, as the identity type is validated before this function is called
 
 	return validation.ValidateStruct(id,
 		validation.Field(&id.Code,

regimes/se/tax_identities.go

@@ -32,10 +32,8 @@ func validateTaxIdentity(tID *tax.Identity) error {
 // Assumes the code has already been normalized, is made of 12 numeric characters,
 // retaining the checksum at the end, plus 2 control digits "01".
 func validateTaxCode(value any) error {
-	code, ok := value.(cbc.Code)
-	if !ok {
-		return nil
-	}
+	// No need for nil check, as the identity type is validated before this function is called
+	code, _ := value.(cbc.Code)
 	if code == "" {
 		return nil
 	}