Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix issues reported by adapter checkern and review testing #774

Open
mcm1957 opened this issue Jun 5, 2024 · 0 comments
Open

Please fix issues reported by adapter checkern and review testing #774

mcm1957 opened this issue Jun 5, 2024 · 0 comments

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Jun 5, 2024

❗ [E034] No devDependency declared for @iobroker/testing. Please add "@iobroker/testing":"4.1.3" to devDependencies at package.json
πŸ‘€ [W028] Minimum node.js version 18 recommended. Please adapt "{'engines' : { 'node' >= '16' } }" at package.json.
πŸ‘€ [W105] Missing suggested translation into uk of "common.titleLang" in io-package.json.
πŸ‘€ [W109] Missing suggested translation into uk of "common.desc" in io-package.json.
πŸ‘€ [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
πŸ‘€ [W174] Potential sensitive data "pass" not listed at "encryptedNative" in io-package.json
πŸ‘€ [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
πŸ‘€ [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
πŸ‘€ [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

TESTING should be updated to current standards. If no technical reason exists, please use standard test-and-release workflow baed on @iobroker/testing 4.x.x.

Alt least testing MUST be adapterd to be performed on all suppoerted platforms 8Linux, window, Mac). Currently tests are executed at Linux only.

@Apollon77
Please check whats possible. If it makes sense to provide a PR based on standard tests please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant