Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowEditing is not working as intended in IOS #1874

Closed
agarshan opened this issue Nov 1, 2023 · 5 comments
Closed

allowEditing is not working as intended in IOS #1874

agarshan opened this issue Nov 1, 2023 · 5 comments

Comments

@agarshan
Copy link

agarshan commented Nov 1, 2023

Bug Report

Plugin(s)

"@capacitor/camera": "^4.1.5"

Capacitor Version

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 5.5.1
  @capacitor/core: 5.5.1
  @capacitor/android: 5.5.1
  @capacitor/ios: 5.5.1

Installed Dependencies:

  @capacitor/cli: 4.8.1
  @capacitor/core: 4.6.1
  @capacitor/ios: 4.6.3
  @capacitor/android: 4.6.2

[success] iOS looking great! 👌
[success] Android looking great! 👌

Platform(s)

IOS

Current Behavior

After taking a picture using camera editing option is not available

Expected Behavior

The user should see the options to edit the image

Code Reproduction

const options: ImageOptions = {
allowEditing: true,
resultType: CameraResultType.Uri,
source: CameraSource.Camera,
quality: 90
};

Camera.getPhoto(options).then(
(imageData) => {
// show image
},
(err) => {
if (err != this.IMAGE_NOT_SELECTED) {
this.emittError(err);
}
}
);

Other Technical Details

Additional Context

Any thoughts, about what is going wrong?

Thanks
Agarshan

@kentora
Copy link

kentora commented Nov 1, 2023

From the documentation for the camera plugin, it says that it is only supported for CameraSource.Camera.

allowEditing boolean Whether to allow the user to crop or make small edits (platform specific). On iOS 14+ it's only supported for CameraSource.Camera, but not for CameraSource.Photos.   1.0.0

@agarshan
Copy link
Author

agarshan commented Nov 1, 2023

From the documentation for the camera plugin, it says that it is only supported for CameraSource.Camera.
allowEditing boolean Whether to allow the user to crop or make small edits (platform specific). On iOS 14+ it's only supported for CameraSource.Camera, but not for CameraSource.Photos. 1.0.0

@kentora currently testing in an ipad 2 - ios version is 15.1 and for CameraSource.Camera its not working

@Ionitron
Copy link
Collaborator

Ionitron commented Nov 1, 2023

This issue needs more information before it can be addressed.
In particular, the reporter needs to provide a minimal sample app that demonstrates the issue.
If no sample app is provided within 15 days, the issue will be closed.

Please see the Contributing Guide for how to create a Sample App.

Thanks!
Ionitron 💙

@agarshan
Copy link
Author

agarshan commented Nov 1, 2023

For iOS, it seems that this plugin only provides the capability to crop images taken with the camera and does not offer other forms of image editing like Markup. Hence closing this issue.

Copy link

ionitron-bot bot commented Nov 16, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants