-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@capacitor/google-maps): Custom tile overlay #1970
base: main
Are you sure you want to change the base?
Conversation
@LaravelFreelancerNL could you provide a example of how to use this new functionality? |
Sure, time allowing I'll supply an example this week. |
It's basically a port of the tileOverlay in the Cordova Google Maps plugin:
Is this what you need? |
Added feature request tag so it can be tracked internally |
Hello Here's the error: It seems that googlemaps doesn't yet know addTileOverlay! ERROR TypeError: _this2.map.addTileOverlay is not a function Can you help me ? home.page.ts : import { Component } from '@angular/core'; import { GoogleMap } from '@capacitor/google-maps'; @component({ export class HomePage { constructor() {} ngOnInit() { async loadMap() {
}// fin loadMap() async ajoute_map_ign(ignKey:string,layer:string,format:string) {
} // fin class HomePage
Ionic CLI : 7.2.0 (C:\Users\Utilisateur\AppData\Roaming\npm\node_modules@ionic\cli) Capacitor: Capacitor CLI : 5.7.2 Utility: cordova-res : 0.15.4 System: NodeJS : v18.16.0 (C:\Program Files\nodejs\node.exe) |
Thanks @clopio, I'll look in to it later this week |
Hello, |
Sorry, more pressing matters have been keeping me busy. The extension is not forgotten though. This plugin was moved to a separate package. So, I'll redo the PR as soon as I have time for it. |
With Ionic 3 and Cordova, it was very easy to display all sorts of maps with addTileoverlay. |
Hi there, @LaravelFreelancerNL it seems your addTileOverlay feature only works on Web platform. |
Hi @FlossyWeb, I've managed to scrounge together the other parts. However, it was originally implemented on capacitor v5. With v6 being out and v7 in the works I haven't been able to get it to work just yet. I've seen it work in the webversion on v5 though. I've forked the separate plugin repo and added the code there in a v6 branch. It will take work and testing to get working. If anyone wants to contribute please do. I'm just the messenger in this case. |
This PR adds the custom tile overlay ability.
Note that this isn't my code. The programmer we hired for the job wasn't able to see it through; however it should be fully functional.
Anyway, we could use some help in case anything needs to be changed.