Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(@capacitor/dialog): Plugin UI uses old UI style and should match device style #2032

Open
JPilson opened this issue Feb 16, 2024 · 2 comments
Labels
platform: android type: feature request A new feature, enhancement, or improvement

Comments

@JPilson
Copy link

JPilson commented Feb 16, 2024

Capacitor Dialog Plugin UI

Plugin

  • Capacitor Dialog

Description

When creating an alert dialog using the Capacitor Dialog Plugin on Android devices, the dialog appears with an old-style design instead of the new material design, even on devices running Android 12. This results in a user experience inconsistency and does not align with the expected system design.

Platform(s)

  • Android

Preferred Solution

The preferred solution is for the Capacitor Dialog Plugin to utilize the default system dialog design on Android devices, especially on newer versions like Android 12, ensuring consistency with the system UI and providing a modern user experience.

Alternatives

One alternative solution could be to provide an option within the plugin configuration to explicitly choose between using the default system dialog design or a custom dialog design.

Additional Context

  • Tested on real devices running Android 12 and on the Android Emulator.
  • The issue seems to stem from the plugin not utilizing the default system dialog design.
  • The current behavior resembles older Android versions such as KitKat, rather than the modern material design.

image

@ionitron-bot ionitron-bot bot added the triage label Feb 16, 2024
@ionitron-bot ionitron-bot bot removed the triage label Feb 16, 2024
@IT-MikeS IT-MikeS changed the title Update Capacitor Dialog Plugin UI bug(@capacitor/dialog): Plugin UI uses old UI style and should match device style Feb 23, 2024
@IT-MikeS IT-MikeS added the type: bug A confirmed bug report label Feb 23, 2024
Copy link

ionitron-bot bot commented Feb 23, 2024

This issue has been labeled as type: bug. This label is added to issues that that have been reproduced and are being tracked in our internal issue tracker.

@eric-horodyski
Copy link
Member

Hi @JPilson, thanks for reaching out!

We're currently evaluating the scope of work required to adopt Material 3 in Capacitor Android. For instance, updating dialogs to align with Material 3 involves changing the Android project's theme and adopting a new API for constructing dialogs. These types of changes are significant and interrelated, so implementing them piecemeal could risk conflicts with other components of a Capacitor Android application.

As we finalize work on Capacitor 7, Material 3 will be a key consideration for Capacitor 8.

@eric-horodyski eric-horodyski added type: feature request A new feature, enhancement, or improvement and removed type: bug A confirmed bug report labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: android type: feature request A new feature, enhancement, or improvement
Projects
None yet
Development

No branches or pull requests

4 participants