Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ionic-pwa produces dynamic import cannot be analyzed by Vite warning #29978

Closed
3 tasks done
muuvmuuv opened this issue Oct 29, 2024 · 2 comments
Closed
3 tasks done
Labels

Comments

@muuvmuuv
Copy link

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

I know that there already was #28576 but this is definitaly produced by the pwa-loader after pwa-camera and other modules are loaded. Vite just prints a warning so I would like to suggested adding /* @vite-ignore */ somewhere to just ignore that part for people building with Vite. Same goes for ionicons I guess it is also happening there.

Expected Behavior

No warning.

Steps to Reproduce

Start Angular Ionic application and add:

import { defineCustomElements } from '@ionic/pwa-elements/loader'
defineCustomElements(window)

Code Reproduction URL

Open for discussions first

Ionic Info

Ionic:

   Ionic CLI                     : 7.2.0 (/Users/marvin/.bun/install/global/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 8.3.1
   @angular-devkit/build-angular : 19.0.0-next.13
   @angular-devkit/schematics    : 19.0.0-next.13
   @angular/cli                  : 19.0.0-next.13
   @ionic/angular-toolkit        : not installed

Capacitor:

   Capacitor CLI      : 6.1.2
   @capacitor/android : 6.1.2
   @capacitor/core    : 6.1.2
   @capacitor/ios     : 6.1.2

Utility:

   cordova-res : not installed globally
   native-run  : not installed globally

System:

   NodeJS : v22.10.0 (/Users/marvin/.proto/tools/node/22.10.0/bin/node)
   npm    : 10.9.0
   OS     : macOS Unknown

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Oct 29, 2024
@muuvmuuv
Copy link
Author

Oh wait sry didnt know pwa-elements has its own repo: ionic-team/pwa-elements#129

Copy link

ionitron-bot bot commented Nov 28, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant