Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: documentation of patterns/antipatterns #768

Open
igorlino opened this issue May 15, 2021 · 4 comments
Open

Improvement: documentation of patterns/antipatterns #768

igorlino opened this issue May 15, 2021 · 4 comments

Comments

@igorlino
Copy link

Stencil version:
@stencil/[email protected]

I'm submitting a:

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
Not necessarely clear what is an anti-pattern and what is a pattern

Expected behavior:
Easy doc to understand/reuse good patterns.
Easy doc to understand and avoid unwanted anti-patterns

Steps to reproduce:
Read https://stenciljs.com/docs/style-guide

Related code:

Other information:

I was reading in InfoQ the article GitHub's Journey with Web Standards and Web Components

And was wondering 2 things, why they did not consider Stencil ? Why did they have to do it themselves.

And then also reading their documentation I found 2 interesting parts
https://github.github.io/catalyst/guide/anti-patterns/
https://github.github.io/catalyst/guide/patterns/

I think documentation of such patterns/anti-patterns could have great benefit for the adoption of Stencil. I imagine from those one could create VisualStudioCode snippet pluggins to speed up even more.

@markcellus
Copy link

why they did not consider Stencil ?

@igorlino This is a very good question. Did you find an answer? I couldn't find anything from the links provided.

@johnjenkins
Copy link
Contributor

Using rails, i think they probably just wanted something that didn’t require node for ssr.
With catalyst they return as much as possible in light dom rendered by the server, then a component enhances it on the client.

@adrm
Copy link

adrm commented Jun 8, 2021

Even better than having to read docs, Stencil provides an eslint plugin with the recommended patterns for working with the library https://github.com/ionic-team/stencil-eslint

That package is sorely outdated, though, so it can't be used directly right now.

@rwaskiewicz
Copy link
Contributor

This is a great point, and something that's been on the team's mind for the past few weeks. I'm going to move this to the Stencil site repo, which is where the documentation for the project lives. Thanks again!

@rwaskiewicz rwaskiewicz transferred this issue from ionic-team/stencil Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants