From 6704b25ba2c177844fa7781d3e34809702bd8c8a Mon Sep 17 00:00:00 2001 From: Ludwig Bedacht Date: Tue, 2 Jan 2024 16:03:52 +0100 Subject: [PATCH] added note --- pkg/scope/cluster.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/scope/cluster.go b/pkg/scope/cluster.go index 13d359e7..123683cb 100644 --- a/pkg/scope/cluster.go +++ b/pkg/scope/cluster.go @@ -118,6 +118,9 @@ func (c *ClusterScope) patchObject() error { // It also implements a retry mechanism to increase the chance of success // in case the patch operation was not successful. func (c *ClusterScope) Finalize() error { + // NOTE(lubedacht) retry is only a way to reduce the failure chance, + // but in general, the reconciliation logic must be resilient + // to handle an outdated resource from that API server. shouldRetry := func(error) bool { return true } return retry.OnError( retry.DefaultBackoff,