New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in creation of mk8s nodepools #255

Closed

leroyshirto opened this issue Jul 11, 2024 · 1 comment

Labels

bug

leroyshirto commented Jul 11, 2024 •

edited

Loading

What happened?

There has been a reversion in functionallity. The fix implemented in PR #243 appears to have been reverted by this recent PR: https://github.com/ionos-cloud/crossplane-provider-ionoscloud/pull/249/files#diff-58333b86186aa1a8ee33021762db2493a983b22ad698c96a8c1377a877eb81c6R323

The result of this is NodePool lan config which only rely on lanCondig e.g

lans:
- dhcp: true
  lanConfig:
    lanIdRef:
      name: my-lan

Will now result in an error as datacenterId will be set to empty string ""

leroyshirto added the bug label

Contributor

cristiGuranIonos commented Jul 31, 2024

fixed in v1.1.2

cristiGuranIonos closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment