-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UGRID test showin version 2.0 #15
Comments
@ChrisBarker-NOAA I was wondering about this too, the conventions page does say version 1. Is there a version 2? Or is that to mean cf-1.11? |
That change happened in #12. I'm not sure we have enough information to answer that questions. The person that submitted that PR is not longer working on RPS as far as I know. With that said. This plugin is kind of abandoned. We are probably better off investing in CF 1.11 in compliance-checker, that includes the UGRID specs, and retire this plugin. |
I’ll need to dig in a bit — it may be 1.1, but certainly not 2. While included in CF 1.11, the CF conventions refer to UGRID, rather than duplicating it — so I believe it has its own version still. |
Sure. I meant more from a Software perspective, retire this repository, and implement it correctly in compliance-checker's CF-1.11 module. If it is CF it should be close to compliance-checker and not a plugin. Does that make sense? |
Sure -- I have no idea the implication of plugin vs part of the base code -- but if that's easier, then great. Any progress is seeing if we can leverage the Met Office's checker? Would that be easier as a plugin? |
It is mostly maintainability. Having the main checkers in a single repo will make things easier.
Not really but I would start with their checker instead of this one for the compliance-checker CF-1.11 implementation. We should also touch base with them again and ask for collaboration. |
when i do
compliance-checker -l
from the command line i get responded with belowwhere ugrid is listed as version 2.0 but from
http://ugrid-conventions.github.io/ugrid-conventions/
states that they're on version 1. Am I missing where 2.0 exists?The text was updated successfully, but these errors were encountered: