Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardNameTable enhancement #727

Open
daltonkell opened this issue Feb 6, 2020 · 0 comments
Open

StandardNameTable enhancement #727

daltonkell opened this issue Feb 6, 2020 · 0 comments

Comments

@daltonkell
Copy link
Contributor

The CF StandardNameTable uses list comprehensions in a variety of places, e.g.

# generate and save a list of all standard names in file
self._names = [node.get('id') for node in self._root.iter('entry')]
self._aliases = [node.get('id') for node in self._root.iter('alias')]
self._version = self._root.xpath('version_number')[0].text

More efficient data structures, such as a set, could be used to improve lookup performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant