-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementing QC on delayed mode data sets #355
Comments
A few questions related to this:
|
@leilabbb - I'm ready to push several delayed-mode datasets to the DAC that have our QC variables in them. What's the status of removing empty DAC QC variables from delayed-mode XMLs so the QC variables aren't duplicated? |
Please see my comments below:
The real-time data sets are not currently undergoing sanity checks. The quick filtering process should get GTS a reliable subset of the data. This process is still not complete as we have encountered problems. My commentary above was about answering the following questions:
Correct, changes will be applied to fix the final product. Discussions are underway to address the issues and implement the necessary improvements. |
Hey Lori, submitting the delayed mode data should not pose any issues. I recommend using distinct QC variable names from those employed by the GDAC for QARTOD, to avoid any potential confusion. |
@leilabbb Thanks Leila! Our QC variable names are different from the GDACs QC variable names, however I still think it will be confusing for users if there are QC variables in the files that are empty (added by the GDAC, e.g. qartod_conductivity_spike_flag) and additional QC variables that are named something slightly different that aren't empty (from us, e.g. conductivity_qartod_spike_test). That just makes the variable lists in these datasets unnecessarily long and confusing. So just to clarify, if I submit a delayed mode dataset, is the GDAC still adding empty QC variables to the dataset? |
Yes, that’s likely, as changes need to be implemented before the QARTOD GDAC variables for delayed mode data sets are no longer on the list of variables. |
Ok, if I submit these datasets now, will the empty QARTOD GDAC variables be removed from the datasets when that change is implemented? Or will the change only be implemented for datasets moving forward after the change is made? |
The changes will be applied to all files including the ones already in the system. |
Exclude QARTOD variables not provided by user for delayed mode datasets.xml has been implemented |
request review by @kbailey-noaa for confirmation on this process. Can be closed per KB input. |
Publish guidance on variable names etc for other users to follow as they attempt to submit delayed mode data sets. |
The data providers or the data users should be involved directly in implementing QC on delayed mode datasets. They should be responsible for submitting their QC results to the DAC with the transparency of what library they have used (ioos_qc or others) and the process that they have followed.
Having the Glider DAC implementing the QC on delayed mode dataset requires the addition of a human in the loop capacity. Otherwise, unchecked QC results will always be at less than 50% completion and not ready to be used by the user.
The text was updated successfully, but these errors were encountered: