Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed missions not passing compliance checker due to qartod variables #385

Open
jenseva opened this issue Oct 23, 2024 · 4 comments
Open
Assignees
Labels

Comments

@jenseva
Copy link

jenseva commented Oct 23, 2024

What went wrong?

Hi There,

When checking on our completed missions to see if they have successfully been sent to NCEI I now see errors related to DAC supplied QARTOD variables.

On page https://gliders.ioos.us/providers/users/jpsevadjian/deployment/64fcec6dbcab6800096055f3, I see:

Compliance Check Report
CF standard name errors must be fixed prior to NCEI archival:

Attribute long_name or/and standard_name is highly recommended for variable qartod_monotonic_pressure_flag

Another mission page (https://gliders.ioos.us/providers/users/jpsevadjian/deployment/660ef6ab24c258000aec233c) shows an additional error:

Compliance Check Report
CF standard name errors must be fixed prior to NCEI archival:

Attribute long_name or/and standard_name is highly recommended for variable qartod_monotonic_pressure_flag
Attribute long_name or/and standard_name is highly recommended for variable qartod_location_flag

I believe these are issues to be resolved by the DAC implementation of QARTOD and are similar to those reported in issue 382.

Should we be concerned about these errors and are they preventing our data from being submitted to NCEI?

Thanks,
Jenn

Operating System

macOS

Version

12.7.1

Python Version

3.9

Code to Reproduce

None. Visit https://gliders.ioos.us/providers/users/jpsevadjian/deployment/660ef6ab24c258000aec233c](https://gliders.ioos.us/providers/users/jpsevadjian/deployment/660ef6ab24c258000aec233c to see the message.

Errors, Traceback, and Logs

Compliance Check Report
CF standard name errors must be fixed prior to NCEI archival:

Attribute long_name or/and standard_name is highly recommended for variable qartod_monotonic_pressure_flag
Attribute long_name or/and standard_name is highly recommended for variable qartod_location_flag
@leilabbb
Copy link
Contributor

working on fixing the ERDDAP catalog variables information to avoid the missing attribute long_name or/and standard_name

@sarinamann-noaa
Copy link

@jenseva
Providing an update from the GDAC team:
The pull request was merged, and changes have been applied but it will take sometimes to see them applied to datasets.

Please feel free to reach out for more information- thank you

@leilabbb
Copy link
Contributor

leilabbb commented Nov 8, 2024

Changes are now seen on ERDDAP. Checkout:

sp028-20230901T1905 dataset' QARTOD variables all include standard names and long names.

sp020-20240403T1710 dataset' QARTOD variables all include standard names and long names.

A rerun of the compliance checker should reflect those fixes.

@leilabbb
Copy link
Contributor

The errors are still showing up in the compliance checker report. The ticket will be closed once the report is updated.

Compliance Check Report
CF standard name errors must be fixed prior to NCEI archival:

Attribute long_name or/and standard_name is highly recommended for variable qartod_monotonic_pressure_flag
Attribute long_name or/and standard_name is highly recommended for variable qartod_location_flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants