Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-agent header not collected #32

Closed
fastfiveoh opened this issue Nov 5, 2018 · 4 comments · May be fixed by #36
Closed

user-agent header not collected #32

fastfiveoh opened this issue Nov 5, 2018 · 4 comments · May be fixed by #36

Comments

@fastfiveoh
Copy link

fastfiveoh commented Nov 5, 2018 •
edited by pselle
Loading

It appears that the user-agent header is not being collected by the IOpipe library when it should be.

Tested on the latest @iopipe/iopipe , 1.15.0 displayed in IOpipe dashboard. Environment is Node v8.10.0, requestor was axios library.
@fastfiveoh
Copy link
Author

This was in conjunction with the use of the Axios library, which when doing an await axios.get(url), did not return the user-agent header when Axios states that is default behavior.

@adjohn
Copy link
Member

adjohn commented Nov 7, 2018

I do see it being collected in Python fwiw:
screen shot 2018-11-07 at 2 35 35 pm

@pselle
Copy link
Contributor

pselle commented Nov 9, 2018

After some investigation, it seems that this may be a simple case where axios sends the header as User-Agent and we're looking for user-agent. We should be normalizing headers/shouldn't lose this.

pselle pushed a commit to pselle/iopipe-plugin-trace that referenced this issue Nov 9, 2018
fix(collection): Normalizes text by case
e6ef030 
We were losing User-Agent headers because they were not user-agent. Normalize data

fix iopipe#32
@pselle pselle mentioned this issue Nov 9, 2018
Open
pselle pushed a commit to pselle/iopipe-plugin-trace that referenced this issue Nov 19, 2018
fix(collection): Normalizes text by case
1786be1 
We were losing User-Agent headers because they were not user-agent. Normalize data

fix iopipe#32
@mrickard
Copy link
Contributor

mrickard commented Oct 1, 2019

User-Agent header for the node agent was restored in https://github.com/iopipe/iopipe-js-trace/releases/tag/v1.5.1

@mrickard mrickard closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(collection): Normalizes text by case pselle/iopipe-plugin-trace
4 participants
@mrickard @adjohn @pselle @fastfiveoh