proper delegator behavior #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkdud007
commented
May 6, 2024
| } | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)] | ||
| pub struct JobData { | ||
| pub reward: u64, | ||
| pub reward: U256, |
There was a problem hiding this comment.
I had switched the type into U256 as it's compatible with deposit function call amount input. Wondering if we could also use U256 in bootloader input type @Okm165
There was a problem hiding this comment.
@rkdud007 I agree.
I also confirmed that on other starknet smart-contracts values/amounts are u256 so it stays this way for sure.
Feel free to change it and other necessary things on a rust side.
I will handle the bootloader compatibility in this PR.
Okm165
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aim to resolve #13
n_stepthat static from cairo progrm (PIE) and dynamic input from delegator.stake&balance_offunction call to cover up delegator node behavior- compiler : input file path -> out put cairo PIE ( responsible of compile )
- registry handler : responsible of streaming subscribed event. As this reponsibility moves registry handler object in mutable state, regarding other contract actions we use node account
- node account : store identity that used in both p2p network and its corresponding starknet account / with this signer and provider, also perform read/write contract call