Initial support for what will be in ietf-asdf-nipc-02 draft #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending items: * Gateway changes * Java SDK and sample app changes * Support for new APIs
rohitmohan96
changed the title
rohitmohan96
changed the title
elear
approved these changes
Oct 25, 2024
| @@ -13,22 +13,21 @@ | |||
|
|
|||
| """ | |||
|
|
|||
| from typing import List, Optional | |||
There was a problem hiding this comment.
Can you explain this change?
There was a problem hiding this comment.
Did they rename List to Sequence?
| Returns: | ||
| TiedieResponse[IDQuery]: Response with the ID of the device. | ||
| """ | ||
| tiedie_request = TiedieBasicRequest(device=device) |
rohitmohan96
added a commit
that referenced
this pull request
Oct 30, 2024
* Updated to latest changes in SCIM draft * Updated to latest changes in SCIM draft * Updated to latest changes in SCIM draft * Initial support for what will be in ietf-asdf-nipc-01 draft. Pending items: * Gateway changes * Java SDK and sample app changes * Support for new APIs * Change dataAppID to uuid in test * Add scim tests * Updated data_app proto * Lint fix * Updated to asdf-nipc-02 APIs * Ignore new pytest error * Minor scim fixes * Lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending items: