Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stateful requester for gossip #597

Open
jonastheis opened this issue Dec 5, 2023 · 1 comment
Open

Implement stateful requester for gossip #597

jonastheis opened this issue Dec 5, 2023 · 1 comment
Labels
nice-to-have team-node Issues for Node Team
Milestone

Comments

@jonastheis
Copy link
Contributor

From here:

the ticker API is bad, where the interaction happens via the Tick event. Thus, you always hook to that event. I think it would be much better design (don't need to do it now) to make the ticker receive a function with the type that gets executed on each tick.

The EventTicker should be changed accordingly.

@alexsporn
Copy link
Member

Tbh I would move away from the event ticker altogether and implement a stateful requester between the network layer and the protocol for #591 that tracks what is being requested, from which peer something was received etc. That is the way we did it in HORNET to avoid flooding neighbours with stuff they already sent to us, etc., and to properly track when stuff was requested, pending, received, etc.

@alexsporn alexsporn added this to the 1.xx milestone Dec 18, 2023
@alexsporn alexsporn added the team-node Issues for Node Team label Jan 11, 2024
@alexsporn alexsporn moved this from Backlog to Product Backlog in iota-core Jan 23, 2024
@muXxer muXxer changed the title Improve EventTicker API Implement stateful requester for gossip Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have team-node Issues for Node Team
Projects
Status: Product Backlog
Development

No branches or pull requests

2 participants