From 38e4f97c151a991056293afce5d41f6e2fda3c7d Mon Sep 17 00:00:00 2001
From: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Date: Wed, 29 Nov 2023 09:31:01 +0100
Subject: [PATCH] Fix `needs_blind_signing()` for non Ed25519 addresses (#1710)

---
 sdk/CHANGELOG.md                     | 4 ++++
 sdk/src/client/secret/ledger_nano.rs | 8 +++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/sdk/CHANGELOG.md b/sdk/CHANGELOG.md
index 4b1fbe3df7..49e228b612 100644
--- a/sdk/CHANGELOG.md
+++ b/sdk/CHANGELOG.md
@@ -29,6 +29,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Display of `WalletError::InsufficientFunds`;
 
+### Fixed
+
+- `needs_blind_signing()` for non Ed25519 addresses;
+
 ## 1.1.2 - 2023-10-26
 
 ### Added
diff --git a/sdk/src/client/secret/ledger_nano.rs b/sdk/src/client/secret/ledger_nano.rs
index 9b67239f5f..aff66f3a6b 100644
--- a/sdk/src/client/secret/ledger_nano.rs
+++ b/sdk/src/client/secret/ledger_nano.rs
@@ -426,11 +426,9 @@ impl SecretManagerConfig for LedgerSecretManager {
 pub fn needs_blind_signing(prepared_transaction: &PreparedTransactionData, buffer_size: usize) -> bool {
     let TransactionEssence::Regular(essence) = &prepared_transaction.essence;
 
-    if !essence
-        .outputs()
-        .iter()
-        .all(|output| matches!(output, Output::Basic(o) if o.simple_deposit_address().is_some()))
-    {
+    if !essence.outputs().iter().all(
+        |output| matches!(output, Output::Basic(o) if o.simple_deposit_address().is_some() && o.address().is_ed25519()),
+    ) {
         return true;
     }