Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve call_client_method and call_wallet_method #1157

Closed
abdulmth opened this issue Sep 6, 2023 · 1 comment
Closed

Improve call_client_method and call_wallet_method #1157

abdulmth opened this issue Sep 6, 2023 · 1 comment
Assignees
@kwek20
Labels
b-nodejs Bindings - Nodejs m-client Module - Client m-wallet Module - Wallet t-refactor Task - Refactor
Milestone
v2.0.0 (Q4 2023)

Comments

@abdulmth
Copy link
Contributor

abdulmth commented Sep 6, 2023 •
edited
Loading

call_client_method and call_wallet_method now panic if the wallet or the client is destroyed. Investigate a way to improve this. Note that using mpsc channel was causing blocking behavior. See #1156 .

Add the removed test if needed https://github.com/iotaledger/iota-sdk/pull/1156/files#diff-0c5d05775aa5ed1e40f101e6865a099c15b79bf8e60247eb25cb7be8e8993c68L136
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Sep 6, 2023
@abdulmth abdulmth added this to the v2.0.0 milestone Sep 6, 2023
@abdulmth abdulmth removed this from iota-sdk Sep 6, 2023
@abdulmth abdulmth added the b-nodejs Bindings - Nodejs label Sep 6, 2023
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Sep 7, 2023
@thibault-martinez thibault-martinez added m-client Module - Client m-wallet Module - Wallet t-refactor Task - Refactor labels Sep 13, 2023
@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Oct 2, 2023
@Thoralf-M
Copy link
Member

Resolved in #1578

@github-project-automation github-project-automation bot moved this from Sprint Backlog to Done in iota-sdk Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwek20 kwek20

Labels
b-nodejs Bindings - Nodejs m-client Module - Client m-wallet Module - Wallet t-refactor Task - Refactor
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q4 2023)
Development

No branches or pull requests
4 participants
@kwek20 @thibault-martinez @abdulmth @Thoralf-M