Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_request query parameter easier to use #1173

Closed
thibault-martinez opened this issue Sep 7, 2023 · 1 comment · Fixed by #1298
Closed

Make get_request query parameter easier to use #1173

thibault-martinez opened this issue Sep 7, 2023 · 1 comment · Fixed by #1298
Assignees
@thibault-martinez
Labels
m-client Module - Client t-refactor Task - Refactor
Milestone
2.0 TIPs (Q4 2023)

Comments

@thibault-martinez
Copy link
Member 

          > Please also add the optional cursor as parameter https://github.com/iotaledger/tips-draft/pull/24/files#diff-04aff9a5004dd8023df5735c866f69254359635764a00e9d9215500a9676319bR2881-R2883 to `get_validators()`

I had a look and I think I'll do it in another PR. The query parameter of get_request is not very handy, it forces us to create the param string ourselves. This should take a vector and build the string inside.

Originally posted by @thibault-martinez in #1165 (comment)
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Sep 7, 2023
@thibault-martinez thibault-martinez added this to the 2.0 TIPs milestone Sep 7, 2023
@thibault-martinez thibault-martinez added m-client Module - Client t-refactor Task - Refactor labels Sep 13, 2023
@thibault-martinez thibault-martinez self-assigned this Sep 18, 2023
@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Sep 19, 2023
@thibault-martinez thibault-martinez moved this from Sprint Backlog to In Progress in iota-sdk Sep 22, 2023
@thibault-martinez thibault-martinez mentioned this issue Sep 22, 2023
Merged
@thibault-martinez
Copy link
Member Author

Closed by #1298

@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-sdk Sep 25, 2023
@thibault-martinez thibault-martinez linked a pull request Sep 25, 2023 that will close this issue
Query parameter function #1298
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thibault-martinez thibault-martinez

Labels
m-client Module - Client t-refactor Task - Refactor
Projects
iota-sdk
Status: Done
Milestone
2.0 TIPs (Q4 2023)
Development

Successfully merging a pull request may close this issue.

Query parameter function thibault-martinez/iota-sdk
1 participant
@thibault-martinez