Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider what should be part of SecretManager or not #1490

Closed
thibault-martinez opened this issue Oct 23, 2023 · 2 comments
Closed

Reconsider what should be part of SecretManager or not #1490

thibault-martinez opened this issue Oct 23, 2023 · 2 comments
Assignees
@DaughterOfMars
Labels
m-client Module - Client t-investigate Task - Investigation
Milestone
v2.0.0 (Q1 2024)

Comments

@thibault-martinez
Copy link
Member 

          Should this be part of the Trait? Seems kind of weird. Maybe we should just remove both.

Originally posted by @DaughterOfMars in #1483 (comment)
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Oct 23, 2023
@thibault-martinez
Copy link
Member Author

Should probably keep the trait to a minimum.
Maybe have a SecretManagerExt if needed.

@DaughterOfMars
Copy link

The alternative cannot be part of the secret manager, because we would still need the bounds on generic types. If we remove anything it would have to be a function that takes a secret manager, perhaps on the wallet or something.

@thibault-martinez thibault-martinez added m-client Module - Client t-investigate Task - Investigation labels Oct 29, 2023
@thibault-martinez thibault-martinez added this to the v2.0.0 milestone Oct 29, 2023
@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Oct 30, 2023
@DaughterOfMars DaughterOfMars mentioned this issue Dec 6, 2023
Closed
@DaughterOfMars DaughterOfMars linked a pull request Jan 11, 2024 that will close this issue
Split Secret Manager traits #1756
Closed
@DaughterOfMars DaughterOfMars moved this from Sprint Backlog to In Progress in iota-sdk Jan 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-sdk Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaughterOfMars DaughterOfMars

Labels
m-client Module - Client t-investigate Task - Investigation
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q1 2024)
Development

Successfully merging a pull request may close this issue.

Split Secret Manager traits iotaledger/iota-sdk
2 participants
@thibault-martinez @DaughterOfMars