Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider what Address Display should be #1587

Closed
thibault-martinez opened this issue Nov 7, 2023 · 2 comments
Closed

Reconsider what Address Display should be #1587

thibault-martinez opened this issue Nov 7, 2023 · 2 comments
Assignees
Labels
m-types Module - Types t-investigate Task - Investigation

Comments

@thibault-martinez
Copy link
Member

          It just forwards to the display impls of the rest of the addresses. We Display only the hex IDs for the addresses. We may want to reconsider what we want as Display but not in this PR I'd say.

Originally posted by @thibault-martinez in #1573 (comment)

@kwek20
Copy link
Contributor

kwek20 commented Dec 14, 2023

So the display of addresses currently looks like this:
Ed25519(hex-encoded-hash)
Account(AccountId(hex-encoded-hash))
Nft(NftId(hex-encoded-hash))
Anchor(AnchorId(hex-encoded-hash))
ImplicitAccountCreation(Ed25519(hex-encoded-hash) )
Multi([
Address(*),
weight
]) -> missing threshold at multi
Restricted(hex-encoded(address+capabilities))

Id propose we completely change multi to the hash(Let Address Hash be the BLAKE2b-256 hash of the serialized Multi Address.), as the others have (my favourite)

No type/kind in display, debug has the name prepended already if thats needed

@thibault-martinez
Copy link
Member Author

Closed by #1790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-types Module - Types t-investigate Task - Investigation
Projects
Status: Done
Development

No branches or pull requests

2 participants