Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider logging more things as warn or even error #317

Closed
Alex6323 opened this issue Apr 24, 2023 · 1 comment
Closed

Consider logging more things as warn or even error #317

Alex6323 opened this issue Apr 24, 2023 · 1 comment
Assignees
@Alex6323
Labels
dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx m-cli Module - CLI t-impl Task - Implementation
Milestone
v1.1.0

Comments

@Alex6323
Copy link
Contributor

Description

Maybe those could be logged as warnings..it would make scraping the archive.log file a bit easier for more unusual scenarios like the following (which to give more context may be related to the 'arithmetic_overflow' panic I had at this day (I can't be sure tho as the panic - see other issue - wasn't logged):

2023-04-14 11:23:48 (UTC) iota_sdk::client::node_manager::http_client DEBUG GET: 26 ms for 404 Not Found https://api.testnet.shimmer.network/api/core/v2/transactions/0xb6c448d3af8c8d065305e33f534c5e0cdd55a800189652361e331ebe312e5805/included-block
2023-04-14 11:23:48 (UTC) iota_sdk::wallet::account::operations::syncing::transactions DEBUG [SYNC] conflicting transaction 0xb6c448d3af8c8d065305e33f534c5e0cdd55a800189652361e331ebe312e5805

Are you planning to do it yourself in a pull request?

Maybe.
@thibault-martinez thibault-martinez added this to the v1.1.0 milestone Apr 28, 2023
@thibault-martinez thibault-martinez added m-cli Module - CLI t-impl Task - Implementation dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx labels May 4, 2023
@Alex6323 Alex6323 mentioned this issue Jul 27, 2023
Merged
@thibault-martinez
Copy link
Member

Closed by #958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex6323 Alex6323

Labels
dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx m-cli Module - CLI t-impl Task - Implementation
Projects
iota-sdk
Status: Done
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@thibault-martinez @Alex6323