Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client::get_slot_index #1158

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Add Client::get_slot_index #1158

merged 5 commits into from
Sep 7, 2023

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Sep 6, 2023

Description of change

Adds Client::get_slot_index based on the old functionality of get_time_checked.

Links to any relevant issues

Closes #1123
Closes #1073

Open Questions

  • Do we want to change the checking at all?
  • Should we even cache the tangle time?
  • Why is the accepted tangle time an optional field?

@DaughterOfMars DaughterOfMars linked an issue Sep 6, 2023 that may be closed by this pull request
Thoralf-M
Thoralf-M previously approved these changes Sep 7, 2023
@thibault-martinez thibault-martinez merged commit 9aa0dd6 into 2.0 Sep 7, 2023
19 of 20 checks passed
@thibault-martinez thibault-martinez deleted the feat/get-slot-index branch September 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Client::get_slot_index
6 participants