From 403b1153ff2e462964c3997a3ca483c46b9ad961 Mon Sep 17 00:00:00 2001
From: Thibault Martinez <thibault@iota.org>
Date: Wed, 22 Nov 2023 15:08:28 +0100
Subject: [PATCH] Add parameters suffix to version signaling

---
 bindings/nodejs/lib/types/models/info/node-info-protocol.ts | 2 +-
 bindings/python/iota_sdk/types/node_info.py                 | 6 +++---
 sdk/src/types/block/protocol.rs                             | 4 ++--
 sdk/tests/types/protocol.rs                                 | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/bindings/nodejs/lib/types/models/info/node-info-protocol.ts b/bindings/nodejs/lib/types/models/info/node-info-protocol.ts
index ad0959d487..592f7accaf 100644
--- a/bindings/nodejs/lib/types/models/info/node-info-protocol.ts
+++ b/bindings/nodejs/lib/types/models/info/node-info-protocol.ts
@@ -102,7 +102,7 @@ export interface ProtocolParameters {
     /**
      * The parameters used by signaling protocol parameters upgrade.
      */
-    versionSignaling: VersionSignalingParameters;
+    versionSignalingParameters: VersionSignalingParameters;
     /**
      * Rewards Parameters defines the parameters that are used to calculate Mana rewards.
      */
diff --git a/bindings/python/iota_sdk/types/node_info.py b/bindings/python/iota_sdk/types/node_info.py
index 67f6dd9201..2b6c184828 100644
--- a/bindings/python/iota_sdk/types/node_info.py
+++ b/bindings/python/iota_sdk/types/node_info.py
@@ -149,7 +149,7 @@ class CongestionControlParameters:
 
 @json
 @dataclass
-class VersionSignaling:
+class VersionSignalingParameters:
     """Version Signaling defines the parameters used by signaling protocol parameters upgrade.
 
     Attributes:
@@ -237,7 +237,7 @@ class ProtocolParameters:
         max_committable_age: Max_committable_age is the maximum age for a slot commitment to be included in a block relative to the slot index of the block issuing time.
         epoch_nearing_threshold: Determine the slot that should trigger a new committee selection for the next and upcoming epoch.
         congestion_control_parameters: Congestion Control Parameters defines the parameters used to calculate the Reference Mana Cost (RMC).
-        version_signaling: The version signaling parameters.
+        version_signaling_parameters: The version signaling parameters.
         rewards_parameters: Rewards Parameters defines the parameters that are used to calculate Mana rewards.
     """
     type: int
@@ -271,7 +271,7 @@ class ProtocolParameters:
         encoder=str
     ))
     congestion_control_parameters: CongestionControlParameters
-    version_signaling: VersionSignaling
+    version_signaling_parameters: VersionSignalingParameters
     rewards_parameters: RewardsParameters
 
 
diff --git a/sdk/src/types/block/protocol.rs b/sdk/src/types/block/protocol.rs
index 4577a31b94..0c3b216e2a 100644
--- a/sdk/src/types/block/protocol.rs
+++ b/sdk/src/types/block/protocol.rs
@@ -82,7 +82,7 @@ pub struct ProtocolParameters {
     /// Parameters used to calculate the Reference Mana Cost (RMC).
     pub(crate) congestion_control_parameters: CongestionControlParameters,
     /// Defines the parameters used to signal a protocol parameters upgrade.
-    pub(crate) version_signaling: VersionSignalingParameters,
+    pub(crate) version_signaling_parameters: VersionSignalingParameters,
     /// Defines the parameters used for reward calculation.
     pub(crate) rewards_parameters: RewardsParameters,
     /// Defines the target size of the committee. If there's fewer candidates the actual committee size could be
@@ -122,7 +122,7 @@ impl Default for ProtocolParameters {
             min_committable_age: 10,
             max_committable_age: 20,
             congestion_control_parameters: Default::default(),
-            version_signaling: Default::default(),
+            version_signaling_parameters: Default::default(),
             rewards_parameters: Default::default(),
             target_committee_size: 32,
         }
diff --git a/sdk/tests/types/protocol.rs b/sdk/tests/types/protocol.rs
index c1918d6950..d8758cb864 100644
--- a/sdk/tests/types/protocol.rs
+++ b/sdk/tests/types/protocol.rs
@@ -64,7 +64,7 @@
 //           "maxBufferSize":1000,
 //           "maxValidationBufferSize":100
 //         },
-//         "versionSignaling":{
+//         "versionSignalingParameters":{
 //           "windowSize":7,
 //           "windowTargetRatio":5,
 //           "activationOffset":7